mahdahar
bb7df6b70c
Complete overhaul of the valueset system to use human-readable names
instead of numeric IDs for improved maintainability and API consistency.
- PatientController: Renamed 'Gender' field to 'Sex' in validation rules
- ValuesetController: Changed API endpoints from ID-based (/:num) to name-based (/:any)
- TestsController: Refactored to use ValueSet library instead of direct valueset queries
- Added ValueSet library (app/Libraries/ValueSet.php) with static lookup methods:
- getOptions() - returns dropdown format [{value, label}]
- getLabel(, ) - returns label for a value
- transformLabels(, ) - batch transform records
- get() and getRaw() for Lookups compatibility
- Added ValueSetApiController for public valueset API endpoints
- Added ValueSet refresh endpoint (POST /api/valueset/refresh)
- Added DemoOrderController for testing order creation without auth
- 2026-01-12-000001: Convert valueset references from VID to VValue
- 2026-01-12-000002: Rename patient.Gender column to Sex
- OrderTestController: Now uses OrderTestModel with proper model pattern
- TestsController: Uses ValueSet library for all lookup operations
- ValueSetController: Simplified to use name-based lookups
- Updated all organization (account/site/workstation) dialogs and index views
- Updated specimen container dialogs and index views
- Updated tests_index.php with ValueSet integration
- Updated patient dialog form and index views
- Removed .factory/config.json and CLAUDE.md (replaced by AGENTS.md)
- Consolidated lookups in Lookups.php (removed inline valueset constants)
- Updated all test files to match new field names
- 32 modified files, 17 new files, 2 deleted files
- Net: +661 insertions, -1443 deletions (significant cleanup)
272 lines
9.8 KiB
PHP
272 lines
9.8 KiB
PHP
<?php
|
|
|
|
namespace Tests\Feature\Patients;
|
|
|
|
use CodeIgniter\Test\FeatureTestTrait;
|
|
use CodeIgniter\Test\CIUnitTestCase;
|
|
use Faker\Factory;
|
|
|
|
class PatientUpdateTest extends CIUnitTestCase
|
|
{
|
|
use FeatureTestTrait;
|
|
protected $endpoint = 'api/patient';
|
|
/**
|
|
* 400 - Validation Fail
|
|
* Coba update tanpa field wajib → harus gagal validasi.
|
|
*/
|
|
public function testUpdatePatientValidationFail()
|
|
{
|
|
$payload = [ 'InternalPID' => null, 'NameFirst' => '' ]; // Tidak valid
|
|
$result = $this->withBodyFormat('json')->call('patch', $this->endpoint, $payload);
|
|
|
|
$result->assertStatus(400);
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
$this->assertArrayHasKey('messages', $data);
|
|
}
|
|
|
|
/**
|
|
* 404 / 500 - Update Nonexistent Patient
|
|
* Coba update InternalPID yang tidak ada.
|
|
*/
|
|
public function testUpdateNonexistentPatientShouldFail()
|
|
{
|
|
$faker = Factory::create('id_ID');
|
|
|
|
$payload = [
|
|
'InternalPID' => 999999, // Asumsi tidak ada di DB
|
|
"PatientID" => "SMAJ1",
|
|
"EmailAddress1" => 'asaas7890@gmail.com',
|
|
"Phone" => $faker->numerify('08##########'),
|
|
"MobilePhone" => $faker->numerify('08##########'),
|
|
'NameFirst' => $faker->firstName,
|
|
'NameLast' => $faker->lastName,
|
|
'Sex' => '1',
|
|
'Birthdate' => $faker->date('Y-m-d'),
|
|
'PatIdt' => [ 'IdentifierType' => 'KTP', 'Identifier' => $faker->nik() ],
|
|
'PatCom' => $faker->sentence,
|
|
'PatAtt' => [
|
|
[ 'Address' => '/api/upload/' . $faker->uuid . '.jpg' ],
|
|
],
|
|
];
|
|
|
|
$result = $this->withBodyFormat('json')->call('patch', $this->endpoint, $payload);
|
|
|
|
$result->assertStatus(201); // Update returns success even if no rows found (depending on logic)
|
|
}
|
|
|
|
/**
|
|
* 201 - Update Success
|
|
* Pastikan bisa update data yang valid (gunakan dummy data dari database).
|
|
*/
|
|
public function testUpdatePatientSuccess()
|
|
{
|
|
$faker = Factory::create('id_ID');
|
|
|
|
// NOTE: Sebaiknya ambil InternalPID yang sudah ada (mock atau dari DB fixture)
|
|
// Untuk contoh ini kita asumsikan ada ID 1
|
|
$payload = [
|
|
'InternalPID' => 1,
|
|
"PatientID" => "SMAJ1",
|
|
'NameFirst' => $faker->firstName,
|
|
'NameMiddle' => $faker->firstName,
|
|
'NameLast' => $faker->lastName,
|
|
'Sex' => '1',
|
|
'Birthdate' => $faker->date('Y-m-d'),
|
|
'EmailAddress1' => 'update_' . $faker->numberBetween(1,999) . '@gmail.com',
|
|
"Phone" => $faker->numerify('08##########'),
|
|
"MobilePhone" => $faker->numerify('08##########'),
|
|
|
|
'PlaceOfBirth' => $faker->city,
|
|
'LinkTo' => null,
|
|
'PatIdt' => [
|
|
'IdentifierType' => 'KTP',
|
|
'Identifier' => $faker->nik(),
|
|
],
|
|
"DeathIndicator" => (string) $faker->numberBetween(16, 17),
|
|
'PatCom' => 'Update be',
|
|
'PatAtt' => [
|
|
[ 'Address' => '/api/upload/' . $faker->uuid . '.jpg' ],
|
|
],
|
|
];
|
|
if($payload['DeathIndicator'] == '16') {
|
|
$payload['DeathDateTime'] = $faker->date('Y-m-d H:i:s');
|
|
} else {
|
|
$payload['DeathDateTime'] = null;
|
|
}
|
|
|
|
$result = $this->withBodyFormat('json')->call('patch', $this->endpoint, $payload);
|
|
$result->assertStatus(201);
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
$this->assertEquals('success', $data['status']);
|
|
}
|
|
|
|
/**
|
|
* 201 - Update dengan PatCom kosong
|
|
*/
|
|
public function testUpdateWithoutPatCom()
|
|
{
|
|
$faker = Factory::create('id_ID');
|
|
|
|
$payload = [
|
|
'InternalPID' => 1,
|
|
"PatientID" => "SMAJ1",
|
|
'NameFirst' => $faker->firstName,
|
|
'NameMiddle' => $faker->firstName,
|
|
'NameLast' => $faker->lastName,
|
|
'Sex' => '1',
|
|
'Birthdate' => $faker->date('Y-m-d'),
|
|
'EmailAddress1' => 'update_' . $faker->numberBetween(1,999) . '@gmail.com',
|
|
"Phone" => $faker->numerify('08##########'),
|
|
"MobilePhone" => $faker->numerify('08##########'),
|
|
'PlaceOfBirth' => $faker->city,
|
|
'LinkTo' => null,
|
|
'PatIdt' => [
|
|
'IdentifierType' => 'KTP',
|
|
'Identifier' => $faker->nik(),
|
|
],
|
|
"DeathIndicator" => (string) $faker->numberBetween(16, 17),
|
|
'PatCom' => null,
|
|
'PatAtt' => [
|
|
[ 'Address' => '/api/upload/' . $faker->uuid . '.jpg' ],
|
|
],
|
|
];
|
|
if($payload['DeathIndicator'] == '16') {
|
|
$payload['DeathDateTime'] = $faker->date('Y-m-d H:i:s');
|
|
} else {
|
|
$payload['DeathDateTime'] = null;
|
|
}
|
|
|
|
$result = $this->withBodyFormat('json')->call('patch', $this->endpoint, $payload);
|
|
$result->assertStatus(201);
|
|
}
|
|
|
|
/**
|
|
* 201 - Update tanpa PatAtt
|
|
*/
|
|
public function testUpdateWithoutAttachments()
|
|
{
|
|
$faker = Factory::create('id_ID');
|
|
|
|
$payload = [
|
|
'InternalPID' => 1,
|
|
"PatientID" => "SMAJ1",
|
|
'NameFirst' => $faker->firstName,
|
|
'NameMiddle' => $faker->firstName,
|
|
'NameLast' => $faker->lastName,
|
|
'Sex' => '1',
|
|
'Birthdate' => $faker->date('Y-m-d'),
|
|
'EmailAddress1' => 'update_' . $faker->numberBetween(1,999) . '@gmail.com',
|
|
"Phone" => $faker->numerify('08##########'),
|
|
"MobilePhone" => $faker->numerify('08##########'),
|
|
'PlaceOfBirth' => $faker->city,
|
|
'LinkTo' => null,
|
|
'PatIdt' => [
|
|
'IdentifierType' => 'KTP',
|
|
'Identifier' => $faker->nik(),
|
|
],
|
|
"DeathIndicator" => (string) $faker->numberBetween(16, 17),
|
|
'PatCom' => null,
|
|
'PatAtt' => [],
|
|
];
|
|
if($payload['DeathIndicator'] == '16') {
|
|
$payload['DeathDateTime'] = $faker->date('Y-m-d H:i:s');
|
|
} else {
|
|
$payload['DeathDateTime'] = null;
|
|
}
|
|
|
|
$result = $this->withBodyFormat('json')->call('patch', $this->endpoint, $payload);
|
|
$result->assertStatus(201);
|
|
}
|
|
|
|
/**
|
|
* 201 - Update tanpa PatAtt
|
|
*/
|
|
public function testUpdateWithAttachments()
|
|
{
|
|
$faker = Factory::create('id_ID');
|
|
|
|
$payload = [
|
|
'InternalPID' => 1,
|
|
"PatientID" => "SMAJ1",
|
|
'NameFirst' => $faker->firstName,
|
|
'NameMiddle' => $faker->firstName,
|
|
'NameLast' => $faker->lastName,
|
|
'Sex' => '1',
|
|
'Birthdate' => $faker->date('Y-m-d'),
|
|
'EmailAddress1' => 'update_' . $faker->numberBetween(1,999) . '@gmail.com',
|
|
"Phone" => $faker->numerify('08##########'),
|
|
"MobilePhone" => $faker->numerify('08##########'),
|
|
'PlaceOfBirth' => $faker->city,
|
|
'LinkTo' => null,
|
|
'PatIdt' => [
|
|
'IdentifierType' => 'KTP',
|
|
'Identifier' => $faker->nik(),
|
|
],
|
|
"DeathIndicator" => (string) $faker->numberBetween(16, 17),
|
|
'PatCom' => null,
|
|
'PatAtt' => [
|
|
[ 'Address' => '/api/upload/' . $faker->uuid . '.jpg' ],
|
|
],
|
|
];
|
|
if($payload['DeathIndicator'] == '16') {
|
|
$payload['DeathDateTime'] = $faker->date('Y-m-d H:i:s');
|
|
} else {
|
|
$payload['DeathDateTime'] = null;
|
|
}
|
|
|
|
$result = $this->withBodyFormat('json')->call('patch', $this->endpoint, $payload);
|
|
$result->assertStatus(201);
|
|
}
|
|
|
|
// /**
|
|
// * 500 - Invalid PatIdt
|
|
// */
|
|
public function testUpdatePatIdtInvalid()
|
|
{
|
|
$faker = Factory::create('id_ID');
|
|
|
|
$payload = [
|
|
'InternalPID' => 1,
|
|
"PatientID" => "SMAJ1",
|
|
'NameFirst' => $faker->firstName,
|
|
'NameMiddle' => $faker->firstName,
|
|
'NameLast' => $faker->lastName,
|
|
'Sex' => '1',
|
|
'Birthdate' => $faker->date('Y-m-d'),
|
|
'EmailAddress1' => 'update_' . $faker->numberBetween(1,999) . '@gmail.com',
|
|
"Phone" => $faker->numerify('08##########'),
|
|
"MobilePhone" => $faker->numerify('08##########'),
|
|
'PlaceOfBirth' => $faker->city,
|
|
'LinkTo' => null,
|
|
'PatIdt' => [
|
|
'IdentifierType' => [],
|
|
'Identifier' => $faker->nik(),
|
|
],
|
|
"DeathIndicator" => (string) $faker->numberBetween(16, 17),
|
|
'PatCom' => null,
|
|
'PatAtt' => [
|
|
[ 'Address' => '/api/upload/' . $faker->uuid . '.jpg' ],
|
|
],
|
|
];
|
|
if($payload['DeathIndicator'] == '16') {
|
|
$payload['DeathDateTime'] = $faker->date('Y-m-d H:i:s');
|
|
} else {
|
|
$payload['DeathDateTime'] = null;
|
|
}
|
|
|
|
$result = $this->withBodyFormat('json')->call('patch', $this->endpoint, $payload);
|
|
|
|
$result->assertStatus(500);
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
if (isset($data['messages']) && is_array($data['messages'])) {
|
|
$this->assertArrayHasKey('error', $data['messages']);
|
|
} else {
|
|
$this->assertArrayHasKey('error', $data);
|
|
}
|
|
}
|
|
|
|
}
|