Complete overhaul of the valueset system to use human-readable names
instead of numeric IDs for improved maintainability and API consistency.
- PatientController: Renamed 'Gender' field to 'Sex' in validation rules
- ValuesetController: Changed API endpoints from ID-based (/:num) to name-based (/:any)
- TestsController: Refactored to use ValueSet library instead of direct valueset queries
- Added ValueSet library (app/Libraries/ValueSet.php) with static lookup methods:
- getOptions() - returns dropdown format [{value, label}]
- getLabel(, ) - returns label for a value
- transformLabels(, ) - batch transform records
- get() and getRaw() for Lookups compatibility
- Added ValueSetApiController for public valueset API endpoints
- Added ValueSet refresh endpoint (POST /api/valueset/refresh)
- Added DemoOrderController for testing order creation without auth
- 2026-01-12-000001: Convert valueset references from VID to VValue
- 2026-01-12-000002: Rename patient.Gender column to Sex
- OrderTestController: Now uses OrderTestModel with proper model pattern
- TestsController: Uses ValueSet library for all lookup operations
- ValueSetController: Simplified to use name-based lookups
- Updated all organization (account/site/workstation) dialogs and index views
- Updated specimen container dialogs and index views
- Updated tests_index.php with ValueSet integration
- Updated patient dialog form and index views
- Removed .factory/config.json and CLAUDE.md (replaced by AGENTS.md)
- Consolidated lookups in Lookups.php (removed inline valueset constants)
- Updated all test files to match new field names
- 32 modified files, 17 new files, 2 deleted files
- Net: +661 insertions, -1443 deletions (significant cleanup)
180 lines
5.0 KiB
PHP
180 lines
5.0 KiB
PHP
<?php
|
|
|
|
namespace Tests\Feature\ValueSet;
|
|
|
|
use CodeIgniter\Test\FeatureTestTrait;
|
|
use CodeIgniter\Test\CIUnitTestCase;
|
|
use App\Libraries\ValueSet;
|
|
|
|
class ValueSetApiControllerTest extends CIUnitTestCase
|
|
{
|
|
use FeatureTestTrait;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
ValueSet::clearCache();
|
|
}
|
|
|
|
public function testIndexReturnsAllLookups()
|
|
{
|
|
$result = $this->call('get', 'api/valueset');
|
|
|
|
$result->assertStatus(200);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('success', $data['status']);
|
|
$this->assertArrayHasKey('gender', $data['data']);
|
|
$this->assertArrayHasKey('specimen_type', $data['data']);
|
|
$this->assertArrayHasKey('order_priority', $data['data']);
|
|
$this->assertArrayHasKey('specimen_status', $data['data']);
|
|
}
|
|
|
|
public function testShowByNameReturnsSingleLookup()
|
|
{
|
|
$result = $this->call('get', 'api/valueset/gender');
|
|
|
|
$result->assertStatus(200);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('success', $data['status']);
|
|
$this->assertIsArray($data['data']);
|
|
$this->assertNotEmpty($data['data']);
|
|
$this->assertArrayHasKey('value', $data['data'][0]);
|
|
$this->assertArrayHasKey('label', $data['data'][0]);
|
|
}
|
|
|
|
public function testShowByNameGenderReturnsCorrectValues()
|
|
{
|
|
$result = $this->call('get', 'api/valueset/gender');
|
|
|
|
$result->assertStatus(200);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$values = array_column($data['data'], 'value');
|
|
$labels = array_column($data['data'], 'label');
|
|
|
|
$this->assertContains('1', $values);
|
|
$this->assertContains('2', $values);
|
|
$this->assertContains('Female', $labels);
|
|
$this->assertContains('Male', $labels);
|
|
}
|
|
|
|
public function testShowByNameInvalidLookupReturns404()
|
|
{
|
|
$result = $this->call('get', 'api/valueset/nonexistent_lookup');
|
|
|
|
$result->assertStatus(404);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('error', $data['status']);
|
|
}
|
|
|
|
public function testShowByNameOrderPriority()
|
|
{
|
|
$result = $this->call('get', 'api/valueset/order_priority');
|
|
|
|
$result->assertStatus(200);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('success', $data['status']);
|
|
$this->assertIsArray($data['data']);
|
|
|
|
$labels = array_column($data['data'], 'label');
|
|
$this->assertContains('Stat', $labels);
|
|
$this->assertContains('ASAP', $labels);
|
|
$this->assertContains('Routine', $labels);
|
|
}
|
|
|
|
public function testCreateReturns403()
|
|
{
|
|
$result = $this->call('post', 'api/valueset', [
|
|
'name' => 'test',
|
|
'values' => []
|
|
]);
|
|
|
|
$result->assertStatus(403);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('error', $data['status']);
|
|
$this->assertStringContainsString('disabled', $data['message']);
|
|
}
|
|
|
|
public function testUpdateReturns403()
|
|
{
|
|
$result = $this->call('patch', 'api/valueset', [
|
|
'name' => 'gender',
|
|
'values' => []
|
|
]);
|
|
|
|
$result->assertStatus(403);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('error', $data['status']);
|
|
$this->assertStringContainsString('disabled', $data['message']);
|
|
}
|
|
|
|
public function testDeleteReturns403()
|
|
{
|
|
$result = $this->call('delete', 'api/valueset', [
|
|
'name' => 'gender'
|
|
]);
|
|
|
|
$result->assertStatus(403);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('error', $data['status']);
|
|
$this->assertStringContainsString('disabled', $data['message']);
|
|
}
|
|
|
|
public function testIndexWithParamFiltersResults()
|
|
{
|
|
$result = $this->call('get', 'api/valueset', ['param' => 'gender']);
|
|
|
|
$result->assertStatus(200);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('success', $data['status']);
|
|
$this->assertIsArray($data['data']);
|
|
}
|
|
|
|
public function testShowByNameSpecimenStatus()
|
|
{
|
|
$result = $this->call('get', 'api/valueset/specimen_status');
|
|
|
|
$result->assertStatus(200);
|
|
|
|
$json = $result->getJSON();
|
|
$data = json_decode($json, true);
|
|
|
|
$this->assertEquals('success', $data['status']);
|
|
$this->assertIsArray($data['data']);
|
|
|
|
$values = array_column($data['data'], 'value');
|
|
$labels = array_column($data['data'], 'label');
|
|
|
|
$this->assertContains('STC', $values);
|
|
$this->assertContains('SCtd', $values);
|
|
$this->assertContains('To be collected', $labels);
|
|
$this->assertContains('Collected', $labels);
|
|
}
|
|
}
|