Complete overhaul of the valueset system to use human-readable names
instead of numeric IDs for improved maintainability and API consistency.
- PatientController: Renamed 'Gender' field to 'Sex' in validation rules
- ValuesetController: Changed API endpoints from ID-based (/:num) to name-based (/:any)
- TestsController: Refactored to use ValueSet library instead of direct valueset queries
- Added ValueSet library (app/Libraries/ValueSet.php) with static lookup methods:
- getOptions() - returns dropdown format [{value, label}]
- getLabel(, ) - returns label for a value
- transformLabels(, ) - batch transform records
- get() and getRaw() for Lookups compatibility
- Added ValueSetApiController for public valueset API endpoints
- Added ValueSet refresh endpoint (POST /api/valueset/refresh)
- Added DemoOrderController for testing order creation without auth
- 2026-01-12-000001: Convert valueset references from VID to VValue
- 2026-01-12-000002: Rename patient.Gender column to Sex
- OrderTestController: Now uses OrderTestModel with proper model pattern
- TestsController: Uses ValueSet library for all lookup operations
- ValueSetController: Simplified to use name-based lookups
- Updated all organization (account/site/workstation) dialogs and index views
- Updated specimen container dialogs and index views
- Updated tests_index.php with ValueSet integration
- Updated patient dialog form and index views
- Removed .factory/config.json and CLAUDE.md (replaced by AGENTS.md)
- Consolidated lookups in Lookups.php (removed inline valueset constants)
- Updated all test files to match new field names
- 32 modified files, 17 new files, 2 deleted files
- Net: +661 insertions, -1443 deletions (significant cleanup)
111 lines
3.6 KiB
PHP
111 lines
3.6 KiB
PHP
<?php
|
|
|
|
namespace Tests\Unit\Lookups;
|
|
|
|
use CodeIgniter\Test\CIUnitTestCase;
|
|
use App\Libraries\Lookups;
|
|
|
|
class LookupsBackwardCompatibilityTest extends CIUnitTestCase
|
|
{
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
\App\Libraries\ValueSet::clearCache();
|
|
}
|
|
|
|
public function testLookupsGetMethodWorks()
|
|
{
|
|
$result = Lookups::get('gender');
|
|
$this->assertIsArray($result);
|
|
$this->assertNotEmpty($result);
|
|
$this->assertArrayHasKey('value', $result[0]);
|
|
$this->assertArrayHasKey('label', $result[0]);
|
|
}
|
|
|
|
public function testLookupsGetRawMethodWorks()
|
|
{
|
|
$result = Lookups::getRaw('gender');
|
|
$this->assertIsArray($result);
|
|
$this->assertNotEmpty($result);
|
|
$this->assertArrayHasKey('key', $result[0]);
|
|
$this->assertArrayHasKey('value', $result[0]);
|
|
}
|
|
|
|
public function testLookupsGetRawGenderContainsExpectedData()
|
|
{
|
|
$result = Lookups::getRaw('gender');
|
|
$keys = array_column($result, 'key');
|
|
$values = array_column($result, 'value');
|
|
|
|
$genderMap = array_combine($keys, $values);
|
|
$this->assertEquals('Female', $genderMap['1']);
|
|
$this->assertEquals('Male', $genderMap['2']);
|
|
}
|
|
|
|
public function testLookupsGetLabelMethodWorks()
|
|
{
|
|
$this->assertEquals('Female', Lookups::getLabel('gender', '1'));
|
|
$this->assertEquals('Male', Lookups::getLabel('gender', '2'));
|
|
$this->assertEquals('Stat', Lookups::getLabel('order_priority', 'S'));
|
|
}
|
|
|
|
public function testLookupsGetAllMethodWorks()
|
|
{
|
|
$result = Lookups::getAll();
|
|
$this->assertIsArray($result);
|
|
$this->assertArrayHasKey('gender', $result);
|
|
$this->assertArrayHasKey('specimen_type', $result);
|
|
$this->assertArrayHasKey('order_priority', $result);
|
|
}
|
|
|
|
public function testLookupsClearCacheMethodWorks()
|
|
{
|
|
Lookups::getAll();
|
|
$result = Lookups::clearCache();
|
|
$this->assertTrue($result);
|
|
}
|
|
|
|
public function testLookupsSameAsValueSet()
|
|
{
|
|
$lookupResult = Lookups::get('gender');
|
|
$valueSetResult = \App\Libraries\ValueSet::get('gender');
|
|
$this->assertEquals($lookupResult, $valueSetResult);
|
|
}
|
|
|
|
public function testLookupsBackwardCompatWithSpecimenStatus()
|
|
{
|
|
$result = Lookups::getRaw('specimen_status');
|
|
$keys = array_column($result, 'key');
|
|
$values = array_column($result, 'value');
|
|
|
|
$statusMap = array_combine($keys, $values);
|
|
$this->assertEquals('To be collected', $statusMap['STC']);
|
|
$this->assertEquals('Collected', $statusMap['SCtd']);
|
|
$this->assertEquals('In-transport', $statusMap['STran']);
|
|
}
|
|
|
|
public function testLookupsBackwardCompatWithMaritalStatus()
|
|
{
|
|
$result = Lookups::getRaw('marital_status');
|
|
$keys = array_column($result, 'key');
|
|
$values = array_column($result, 'value');
|
|
|
|
$statusMap = array_combine($keys, $values);
|
|
$this->assertEquals('Married', $statusMap['M']);
|
|
$this->assertEquals('Single', $statusMap['S']);
|
|
$this->assertEquals('Divorced', $statusMap['D']);
|
|
}
|
|
|
|
public function testLookupsBackwardCompatWithReligion()
|
|
{
|
|
$result = Lookups::getRaw('religion');
|
|
$keys = array_column($result, 'key');
|
|
$values = array_column($result, 'value');
|
|
|
|
$religionMap = array_combine($keys, $values);
|
|
$this->assertEquals('Islam', $religionMap['ISLAM']);
|
|
$this->assertEquals('Kristen', $religionMap['KRSTN']);
|
|
$this->assertEquals('Katolik', $religionMap['KTLIK']);
|
|
}
|
|
}
|